perf: speed up device inventory and status - #1723
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Reviewed exact head |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The change touches 9 files and stays within the devices/device-status command family and their shared process-liveness seam. No docs or skills changed because command syntax, output shape, and workflow guidance are unchanged.
Validation
pnpm check:affected --runpassed immediately before push: 296 test files / 2,655 tests, 95% changed-line coverage, plus format, lint, typecheck, layering, Fallow, build, interaction contracts, and provider integration.Regression evidence: the Apple concurrency test failed before the production change because only simctl started while simulator discovery was blocked; it passes with physical discovery starting concurrently. Batched process observation is covered by a one-ps-call test and fail-closed missing-observation coverage.
Manual host timing used the real Apple device services and 159 advisory claims. Cold CoreDevice startup remains externally variable and produced one ~11s outlier; the fix removes serialized simulator latency from that path rather than caching potentially stale inventory.