test: fail closed on unknown recording provider commands - #1728
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Android recording provider fixture fail closed when production executes an unmodeled command. Explicitly model process enumeration and recording-artifact commands, and align the native-manifest fixture with the production contract where export quality is optional.
This makes provider transcript drift fail loudly instead of returning a fabricated successful result. It is the first bounded Tier A hardening step from #1680; it does not introduce a generic virtual-device framework.
Validation
The new tracer was first observed red with
Missing expected rejectionagainst the previous catch-all response. Tightening then exposed and replaced two hidden fixture assumptions: unmodeled process enumeration and a falsely required export-quality field.pnpm check:affected --runpasses, including formatting, lint, full typecheck, Fallow, and four related provider-integration files with 8/8 tests.