Repository navigation
refactor(daemon): move the runtime dependency construction to the process root (PR 6) #3431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thymikee
wants to merge
3
commits into
main
Choose a base branch
from
refactor/daemon-composition-root
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+777
−580
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,14 @@ Accepted (2026-09-06). Implements the audit deliverables of issue #2278. The cla | |||||
| inventory and the structural no-regrowth checks are gate-enforced; this ADR records the decisions | ||||||
| and points at the gates rather than restating the inventory. | ||||||
|
|
||||||
| Amended 2026-10-11 by the PR-6 composition extraction: the daemon-runtime composition edges this | ||||||
| ADR classified (the gateway/diagnostics/resource-cleanup/lifecycle edges, the provider-runtime | ||||||
| hubs, and the platform-services and claim-recovery dynamic edges) moved out of `src/daemon/` into | ||||||
| the process-root composition module `src/daemon-composition.ts`, which R76 does not see because it | ||||||
| is no longer a daemon-zone importer. The R76 inventory now carries only the leaked | ||||||
| selector-query edge (`daemon/direct-ios-selector.ts`); the section-2 outcomes above remain the | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: This R76 importer path omits the Prompt for AI agents
Suggested change
|
||||||
| record of how each was classified. | ||||||
|
|
||||||
| ## 1. Context | ||||||
|
|
||||||
| The platform-package migration removed direct production dependencies from `src/daemon/**` to | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /** | ||
| * The provider credentials a daemon started with, and the state dir that names that daemon. | ||
| * | ||
| * A `lease_allocate` request carries the caller's own fingerprint so a lease can be fenced to one | ||
| * credential set (#2559): the daemon compares the request's value against the fingerprint it | ||
| * computed from its own startup environment, and both sides read this one declaration — the | ||
| * daemon's implementation stays in the process root (`src/provider-credential-fingerprint.ts`), | ||
| * which the daemon client imports; the vocabulary lives here because that fingerprint module must | ||
| * not carry a type edge into `src/daemon` (#2559). | ||
| */ | ||
| export type DaemonProviderCredentials = Readonly<{ | ||
| /** Undefined when the daemon's environment holds none of the credentials such a lease reads. */ | ||
| fingerprint(provider: string, leaseBackend?: string): string | undefined; | ||
| stateDir: string; | ||
| }>; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Section 2 follows this amendment, so “above” points readers in the wrong direction. Change it to “below.”
Prompt for AI agents