Repository navigation
Conversation
…e goes `help trace` printed `trace start <path> | trace stop <path>`, but both paths are optional: start falls back to the session's default trace path and a path on stop moves the finished trace there (trace-runtime.ts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
I found no problems in 5026910. The change to show trace paths as optional in the help output looks right. All 19 checks pass and there are no conflicts, so it is ready for review. I did not read the body of defaultTracePath, so I have not checked the "timestamped" wording in the description. I also did not look for generated docs or skills that quote the old usage, beyond a grep that found no copies of the old |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-device help traceprintedtrace start <path> | trace stop <path>, which marks the path as required, and its description said "when an explicit path is required". Both paths are optional:trace startwith no path writes a timestamped trace log named after the session in the daemon's sessions directory (trace-runtime.ts:34,SessionStore.defaultTracePath).trace stop <path>moves the finished trace to that path (relocateTraceOutput).The command schema already declared the path optional (
positionalArgs: ['start|stop', 'path?']); only the hand-written usage and description were wrong. This PR:trace start [path] | trace stop [path]command-surface-metadata.test.tsenforces.cliDetailline that repeated the wrong rulecli-help-topics.test.tsassertion that pinned the wrong usageFound while trimming
commands.md(#3441), which already documentstrace start [path].Validation
pnpm check:affected --runpassed on 5026910.cli-help-topicsandcommand-surface-metadatapass (37 tests).help tracenow printstrace start [path] | trace stop [path].🤖 Generated with Claude Code