Repository navigation
Conversation
krozniata
force-pushed
the
chore/workspaces
branch
from
October 9, 2026 08:17
38cf444 to
e52469f
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Package-manager compatibility and native workflow trigger gaps must be addressed.
2 open findings
What changed in this PR
Migrates the repository’s library, example app, and e2e suite to a unified Bun workspace with hoisted dependencies.
Changes:
- Adds Bun workspaces and consolidates lockfiles.
- Updates native and Metro paths for hoisted dependencies.
- Simplifies bootstrap and CI installation steps.
| File | Description |
|---|---|
package.json |
Defines workspaces and shared linking. |
example/package.json |
Removes duplicated tooling configuration. |
example/metro.config.js |
Resolves the local library through workspace linking. |
example/ios/Podfile.lock |
Updates pods for hoisted dependencies. |
example/ios/PagerViewExample.xcodeproj/project.pbxproj |
Updates React Native paths. |
example/android/settings.gradle |
Updates Gradle plugin paths. |
example/android/app/build.gradle |
Configures hoisted React Native tooling. |
e2e/README.md |
Documents root workspace installation. |
e2e/bun.lock |
Removes the redundant e2e lockfile. |
CONTRIBUTING.md |
Documents unified installation. |
bunfig.toml |
Enables hoisted linking. |
bun.lock |
Consolidates workspace dependencies. |
.github/workflows/main.yml |
Uses one root install. |
.github/workflows/ios.yml |
Uses workspace-installed dependencies. |
.github/workflows/android.yml |
Uses workspace-installed dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "overrides": { | ||
| "eslint-plugin-ft-flow": "^3.0.11" | ||
| "eslint-plugin-ft-flow": "^3.0.11", | ||
| "react-native-pager-view": "link:." |
Comment on lines
+23
to
+25
| "workspaces": [ | ||
| "example", | ||
| "e2e" |
krozniata
marked this pull request as ready for review
October 9, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md