Skip to content

fix: use readFileSync instead of require in validatePlugins #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbroma merged 2 commits into from
May 4, 2025
Merged

fix: use readFileSync instead of require in validatePlugins #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46a76c8
fix: use readFileSync instead of require
jbroma May 4, 2025
6c30574
chore: changeset
jbroma May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/good-mirrors-bow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack": patch
---

Fix failure to read project package json when validating plugins
6 changes: 4 additions & 2 deletions packages/repack/src/commands/common/config/validatePlugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import fs from 'node:fs';
import path from 'node:path';
import { bold } from 'colorette';

Expand Down Expand Up @@ -34,8 +35,9 @@ export async function validatePlugins(
);

try {
const packageJson = require(path.join(rootDir, 'package.json'));
dependencies = Object.keys(packageJson.dependencies || {});
const packageJsonPath = path.join(rootDir, 'package.json');
const packageJson = fs.readFileSync(packageJsonPath, 'utf-8');
dependencies = Object.keys(JSON.parse(packageJson).dependencies || {});
} catch (error) {
if ((error as NodeJS.ErrnoException).code === 'ENOENT') {
console.debug(
Expand Down