feat: expose cache entry on shouldUpdateScript

[ElielC]

Summary

Exposes a new property on locator.shouldUpdateScript in order to enable more custom caching behaviors on afterResolve hooks, following this discussion

Test plan

Ensure all tests pass and there are no regression issues

[changeset-bot]

🦋 Changeset detected

Latest commit: 864bb7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@callstack/repack	Major
@callstack/repack-plugin-expo-modules	Major
@callstack/repack-plugin-nativewind	Major
@callstack/repack-plugin-reanimated	Major
@callstack/repack-dev-server	Major
@callstack/repack-init	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@ElielC is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

[dannyhw]

Nice one @ElielC 🙌

[ElielC]

The changeset bot references the release as a Major, but i created the changeset as a Minor release, is that right?

[dannyhw]

Thats strange, @jbroma is this a bug with the changesets bot?

[jbroma]

The changeset bot references the release as a Major, but i created the changeset as a Minor release, is that right?

hey, sorry for lack of activity lately, changesets can always be adjusted manually before the release so no need to worry about that

[MikitasK]

overall, these changes looks good to me 👍 also core behavior works as expected on my side ☑️
just a few minor comments:

[MikitasK]

This code assumes cachedData always exists, but it might be undefined on first load. so let's guard no-cache case before dereferencing cachedData

Suggested change

	// Custom logic to determine if the script should be updated
	return (
	cachedData.method !== locator.method ||
	cachedData.url !== locator.url ||
	cachedData.query !== locator.query ||
	!shallowEqual(cachedData.headers, locator.headers) ||
	cachedData.body !== locator.body
	);
	};
	// Custom logic to determine if the script should be updated
	if (!cachedData) return true;
	return (
	cachedData.method !== locator.method ||
	cachedData.url !== locator.url ||
	cachedData.query !== locator.query ||
	!shallowEqual(cachedData.headers, locator.headers) ||
	cachedData.body !== locator.body
	);
	};

[MikitasK]

I’d also suggest adding a unit test covering for these cases:

• cachedData === undefined on first load
• cachedData populated on subsequent load
• changed locator making isScriptCacheOutdated === true

[MikitasK]

passing this.cache[cacheKey] directly into shouldUpdateScript implies that users receive the actual cached object, not a defensive copy. which means that Re.Pack’s internal cache entry might be affected If user's code mutates cachedData. so, I'd prefer to pass it in more safer way:

Suggested change

	script.shouldUpdateCache(this.cache[cacheKey]),
	this.cache[cacheKey]
	script.shouldUpdateCache(this.cache[cacheKey]),
	this.cache[cacheKey] ? { ...this.cache[cacheKey] } : undefined

[bartekkrok]

This looks like a solid addition!

Could you add a test case that specifically covers this scenario ?