chore: remove the legacy xano command - #206
Conversation
🦋 Changeset detectedLatest commit: fa7b3c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis PR removes legacy ChangesRemove legacy xano command support
🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/cli/esbuild.config.tsOops! Something went wrong! :( ESLint: 9.39.4 Error: You are using an outdated version of the 'jiti' library. Please update to the latest version of 'jiti' to ensure compatibility and access to the latest features. Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cli/package.json (1)
45-56:⚠️ Potential issue | 🟠 MajorFix SEA bundling:
postjectis still required
packages/cli/build-sea.tsrunsnpx postject ...viaexecSync(lines 53-55) as part of"bundle:sea": "tsx build-sea.ts"(and"bundle"), so removingpostjectfrompackages/cli/package.jsondevDependencies will break the SEA injection step. Re-addpostject(or changebuild-sea.tsto avoid using it).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/cli/package.json` around lines 45 - 56, The SEA bundling step still relies on running `npx postject` from build-sea.ts (the execSync call around the `execSync` usage in build-sea.ts and the npm script "bundle:sea"), so restore `postject` in packages/cli/package.json devDependencies (or alternatively refactor build-sea.ts to remove the `execSync('npx postject ...')` call and implement SEA injection natively). Specifically, either add `postject` back into the "devDependencies" block of package.json so the `npx postject` call succeeds, or edit build-sea.ts to replace the `execSync` call that invokes postject with a direct implementation that performs the same injection so the package.json change isn’t required.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/cruel-rings-play.md:
- Line 2: The changeset currently lists the `@calycode/cli` update as "patch" but
removing the xano CLI command is a breaking pre-1.0 change and must be released
as "minor"; update the entry for "`@calycode/cli`" in the
.changeset/cruel-rings-play.md file to use minor instead of patch so the release
follows the repo's pre-1.0 policy.
---
Outside diff comments:
In `@packages/cli/package.json`:
- Around line 45-56: The SEA bundling step still relies on running `npx
postject` from build-sea.ts (the execSync call around the `execSync` usage in
build-sea.ts and the npm script "bundle:sea"), so restore `postject` in
packages/cli/package.json devDependencies (or alternatively refactor
build-sea.ts to remove the `execSync('npx postject ...')` call and implement SEA
injection natively). Specifically, either add `postject` back into the
"devDependencies" block of package.json so the `npx postject` call succeeds, or
edit build-sea.ts to replace the `execSync` call that invokes postject with a
direct implementation that performs the same injection so the package.json
change isn’t required.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5d950f12-00b8-46e7-aaf6-3a749282c5b1
📒 Files selected for processing (4)
.changeset/cruel-rings-play.mdpackages/cli/esbuild.config.tspackages/cli/package.jsonpackages/cli/src/legacy-xano-command.ts
💤 Files with no reviewable changes (1)
- packages/cli/src/legacy-xano-command.ts
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@calycode/cli": patch | |||
There was a problem hiding this comment.
Use a minor changeset for this command removal.
Line 2 marks this as patch, but removing the xano command is a breaking CLI contract change and should follow the repo’s pre-1.0 policy as minor.
Suggested fix
-"`@calycode/cli`": patch
+"`@calycode/cli`": minorBased on learnings, breaking changes for pre-1.0 internal packages in this repo are intentionally released as minor, and non-minor is treated as incorrect.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@calycode/cli": patch | |
| "`@calycode/cli`": minor |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/cruel-rings-play.md at line 2, The changeset currently lists the
`@calycode/cli` update as "patch" but removing the xano CLI command is a breaking
pre-1.0 change and must be released as "minor"; update the entry for
"`@calycode/cli`" in the .changeset/cruel-rings-play.md file to use minor instead
of patch so the release follows the repo's pre-1.0 policy.
Source: Learnings
1 participant
Summary by CodeRabbit
Release Notes
xanocommand from CLI.caly-xanois now the primary command-line interface.