Skip to content

Geofencing Subscriptions: Add support for PRIVATE_KEY_JWT#393

Open
jlurien wants to merge 7 commits intomainfrom
geofencing-subscriptions-add-PRIVATE_KEY_JWT
Open

Geofencing Subscriptions: Add support for PRIVATE_KEY_JWT#393
jlurien wants to merge 7 commits intomainfrom
geofencing-subscriptions-add-PRIVATE_KEY_JWT

Conversation

@jlurien
Copy link
Copy Markdown
Collaborator

@jlurien jlurien commented Apr 20, 2026

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Align with Commonalities Spring'26
Reference: camaraproject/Commonalities#580

Which issue(s) this PR fixes:

Fixes #392

Changelog input

Added support for credential type PRIVATE_KEY_JWT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ API spectral 3 0 4.76s
✅ GHERKIN gherkin-lint 3 0 1.26s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.72s
✅ YAML yamllint 3 0 1.01s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@jlurien jlurien added the Sync26 In scope for Sync26 Meta-release label Apr 21, 2026
Comment thread code/API_definitions/geofencing-subscriptions.yaml Outdated
Comment thread code/API_definitions/geofencing-subscriptions.yaml Outdated
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
discriminator:
propertyName: credentialType
mapping:
PLAIN: "#/components/schemas/PlainCredential"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove PLAIN from the spec ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is probably something to double check with Commonalities as PLAIN is not present in https://github.com/camaraproject/Commonalities/blob/main/artifacts/common/CAMARA_event_common.yaml

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the artifact it is commented out, so we should apply the same here, or remove it completely if it is expected to be a permanent decision

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I have commented it out to be aligned

Comment thread code/Test_definitions/geofencing-subscriptions.feature Outdated
@jlurien jlurien requested a review from alpaycetin74 April 30, 2026 14:40
Comment thread code/Test_definitions/geofencing-subscriptions.feature Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sync26 In scope for Sync26 Meta-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PRIVATE_KEY_JWT as new credential type to Geofencing Subscription API

3 participants