fix: add missing 'type' on CloudEvent and Status schemas#555
Merged
hdamker merged 1 commit intoMay 29, 2026
Merged
Conversation
hdamker
requested review from
RandyLevensalor,
eric-murray and
jlurien
as code owners
eric-murray
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Adds three missing
type:declarations flagged by CAMARA Validation rule S-016 (camara-schema-type-check):code/API_definitions/qos-provisioning.yaml:type: objectonCloudEvent,type: stringonStatuscode/API_definitions/quality-on-demand.yaml:type: objectonCloudEventThree single-line additions. No other changes.
Which issue(s) this PR fixes:
Fixes #554
Special notes for reviewers:
This is a temporary fix. The durable solution is to refactor both API definitions to consume the canonical Commonalities common schemas via
$refintocode/common/CAMARA_event_common.yaml(andCAMARA_common.yaml), as enabled by Commonalities r4.2 — removing the inlinedCloudEventcopies entirely.Changelog input
Additional documentation
This section can be blank.