Skip to content

fix: align common files and templates with Commonalities #606#67

Merged
hdamker-bot merged 1 commit intomainfrom
fix/align-with-commonalities-606
Apr 7, 2026
Merged

fix: align common files and templates with Commonalities #606#67
hdamker-bot merged 1 commit intomainfrom
fix/align-with-commonalities-606

Conversation

@hdamker
Copy link
Copy Markdown
Contributor

@hdamker hdamker commented Apr 7, 2026

What type of PR is this?

correction

What this PR does / why we need it:

Aligns ReleaseTest common files and API templates with the latest state of Commonalities PR #606 (artifacts restructuring) and fixes all validation errors and actionable warnings reported by the validation framework run.

Common files synced from #606:

  • CAMARA_common.yaml: TimePeriod properties use $ref to DateTime schema
  • CAMARA_event_common.yaml: add notificationsBearerAuth securityScheme, comment out PLAIN credential (not used in CAMARA)

Validation errors fixed (6 → 0):

  • P-016: remove sinkCredential from Subscription response schema (must not appear in responses per Design Guide)
  • P-015: replace api-name placeholders with sample-service-subscriptions in event type strings (matching filename convention used by all CAMARA subscription APIs, e.g. device-roaming-status-subscriptions)

Validation warnings fixed (4 → 1):

  • S-318: add Generic400 error responses to GET/DELETE operations in sample-service.yaml (OWASP define-error-validation)
  • Remaining: GET /status in release-test.yaml skipped (no input params, uses inline schemas)

Additional alignment:

  • notificationsBearerAuth in subscription template now uses $ref to CAMARA_event_common.yaml
  • x-camara-commonalities version corrected from 0.8.0 to 0.7.0

Which issue(s) this PR fixes:

n/a — maintenance alignment

Special notes for reviewers:

The corresponding changes for sample-service.yaml (400 responses) and sample-service-subscriptions.yaml (api-name replacement) are also prepared as commits on Commonalities PR #606.

Changelog input

release-note
n/a — test repository maintenance

Additional documentation

docs
n/a

Sync common files to latest Commonalities PR #606:
- CAMARA_common.yaml: TimePeriod uses $ref to DateTime
- CAMARA_event_common.yaml: add notificationsBearerAuth securityScheme,
  comment out PLAIN credential (not used in CAMARA)

Fix validation errors and warnings:
- Remove sinkCredential from Subscription response schema (P-016)
- Replace api-name placeholders with sample-service-subscriptions in
  event types (P-015)
- Update notificationsBearerAuth to $ref from CAMARA_event_common.yaml
- Fix x-camara-commonalities version 0.8.0 -> 0.7.0
- Add Generic400 responses to sample-service.yaml GET/DELETE (S-318)
@hdamker hdamker requested a review from hdamker-bot as a code owner April 7, 2026 15:02
@camara-validation
Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 1 warnings, 23 hints | Profile: standard

View full results

@hdamker-bot hdamker-bot merged commit 4c6bbaf into main Apr 7, 2026
3 checks passed
@hdamker hdamker deleted the fix/align-with-commonalities-606 branch April 8, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants