enhance: Possibly breaking down MediaSessionInformation into distinct schema #164
Conversation
Updated references for media session schemas and added new schemas for MediaSessionCreate, MediaSessionResponse, and MediaSessionStatusChange.
Updated examples for media session status changes to include SDP answers and refined existing examples.
|
@teikuran The schema decomposition approach is well-structured and correctly addresses Issue #147 (in the right direction). One request before merge: please rebase this PR on top of PR #142 once it is checked in. The |
Added mediaSessionId to the WebRTC call handling definition.
stroncoso
left a comment
There was a problem hiding this comment.
LGTM
There are commonalities warnings, but they can be reviewed later
There was a problem hiding this comment.
Issue: offer required in MediaSessionResponse breaks the receiver pick-up flow
MediaSessionResponse marks offer as required, and this schema is used for all GET responses. However, in the receiver pick-up flow, the callee retrieves the session immediately upon receiving a session-invitation event — before any SDP exchange has occurred. If the originator used the deferred-offer path, the session at GET time will have no offer, causing the response to fail schema validation.
This is further contradicted by the WrtcSDPDescriptor description, which explicitly states the answer element may be absent when no answer exists yet — acknowledging that partial-state sessions are valid.
Suggestion: Remove offer from the required list in MediaSessionResponse.
|
Issue:
This is a leftover from before the refactor. The intent of breaking up Suggestion: Remove |
Thank you for your comment. Based on the current specification, it appears that the callee is expected to have an SDP offer available when retrieving the session after receiving a Regarding the reference to Furthermore, with telco network, it is defined in 3GPP that the UE shall contain a SDP offer.
Thank you. We will incorporate the comment as indicated. |
@teikuran I agree with your feedback. We, currently do not support deferred offer. |
|
Conflict probably generated by the Commonalities/ICM v4.2 merge #174 , sorry 🙇 Anyway, the fix is easily covered from the web editor accepting the current change, not the incomming. Couple of clicks ahead. An screenshot here:
|
Removed redundant required fields from MediaSessionResponse schema.
|
@teikuran , @deepakjaiswal1 up to you to merge when you consider. Thank you! 🙇 |

What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
To address following issues:
The current API definition re-uses the MediaSessionInformation schema, using it as the message body for almost all operations, including POST requests/responses, GET responses, and PUT requests/responses.
This leads to ambiguity e.g., currently, receiverAddress is not marked as required in the MediaSessionInformation schema. This allows a client to technically submit a call initiation request without a destination, which is functionally invalid.
Which issue(s) this PR fixes:
Fixes #147
Changelog input