Skip to content

Separated Vertica SQL dialect from Ruby vertica driver. Added ODBC - #18

Open
abramclark wants to merge 3 commits into
camilo:masterfrom
abramclark:odbc-driver
Open

Separated Vertica SQL dialect from Ruby vertica driver. Added ODBC#18
abramclark wants to merge 3 commits into
camilo:masterfrom
abramclark:odbc-driver

Conversation

@abramclark

Copy link
Copy Markdown

No description provided.

@abramclark

Copy link
Copy Markdown
Author

@camilo how does this look?

@camilo

camilo commented Jul 14, 2017

Copy link
Copy Markdown
Owner

@abramclark interesting!;
So the intention is to add the ODBC driver?

I don't fully understand the refactor that moves some code to lib/sequel/adapters/shared/vertica.rb what is the intention there?

@abramclark

abramclark commented Jul 14, 2017

Copy link
Copy Markdown
Author

@camilo sequel/adapters/shared/vertica.rb is just for SQL generation, and sequel/adapters/vertica is for code that depends on the Ruby Vertica driver. I based this off of recommendations from Jeremy, the sequel maintainer, and basically copied code from mysql, mssql, etc adapters. The ODBC functionality is working for me in testing, and I may be using it in production soon. This was motivated by my org requiring all DB connections to use ODBC.

…te record is returned instead of first in collection. Only supports IDENTITY / AUTO_INCREMENT columns and not sequences. Very similar fix is still needed for Ruby vertica adapter.
@abramclark

abramclark commented Jul 18, 2017

Copy link
Copy Markdown
Author

@camilo there's a major issue where model.save returns the first instance in the collection instead of the one created. I mostly fixed it for the ODBC version, but since I don't use the Ruby vertica driver I have no plans to fix it there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants