Skip to content

Conversation

@papsti
Copy link

@papsti papsti commented Mar 20, 2025

this PR is meant for small changes to workshop materials that come up as we work through them as a group today!

please do not consider incorporating it until end of day 2025-03-20

@papsti
Copy link
Author

papsti commented Mar 20, 2025

one of the edits relates to installation. this is a fix that seems to only have been required for someone working in an renv environment on a linux server (me :))

another thing people came across is that install.packages(DEoptim) was required to run the sample code at the bottom of the technical preparation. this bit probably requires a fix to package dependencies, as opposed to installation instructions.

@papsti
Copy link
Author

papsti commented Mar 20, 2025

another note: the requirement to install.packages("DEoptim") seems to have been introduced between [email protected] and [email protected]

@bbolker
Copy link
Collaborator

bbolker commented Mar 20, 2025

I don't what our general policy on dependencies is, but unless a package is critical it would be best if we could include it as Suggests: rather than Imports:

@papsti
Copy link
Author

papsti commented Mar 20, 2025

it would be great to have a top-level graphic/map of all the different types of macpan objects (model specification, simulator, calibrator, etc) and which functions get used to convert one type of object to the other + the types of outputs you can get from each (e.g. represented with plots)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants