Skip to content

doc: fix inaccurate note about script users default - #449

Open
jmucc wants to merge 1 commit into
canonical:mainfrom
jmucc:fix-script-users-doc
Open

doc: fix inaccurate note about script users default#449
jmucc wants to merge 1 commit into
canonical:mainfrom
jmucc:fix-script-users-doc

Conversation

@jmucc

@jmucc jmucc commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

I was following this file to test script execution briefly for the upgrade (it's the top result for "landscape client.conf"). In my testing I found that you have to explicitly specify script_users, meaning the comment here is inaccurate. I verified as much in the code but that could use double checking. Here is my source:

landscape/client/manager/config.py

    def get_allowed_script_users(self):
        """
        Based on the C{script_users} configuration value, return the users that
        should be allowed to run scripts.

        If the value is "ALL", then
        L{landscape.manager.scriptexecution.ALL_USERS} will be returned.  If
        there is no specified value, then C{nobody} will be allowed.
        """
        if not self.script_users:
            return ["nobody"]
        if self.script_users.strip() == "ALL":
            return ALL_USERS
        return [x.strip() for x in self.script_users.split(",")]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant