feat: Add GraphiQL link to index page#221
Merged
schwma merged 8 commits intocap-js:mainfrom Jan 21, 2026
Merged
Conversation
…that adds a GraphiQL link to the service index HTML page for GraphQL endpoints, making it easier to access the GraphiQL interface.
Contributor
Author
|
Work related to issue #220 |
schwma
requested changes
Jan 19, 2026
Member
schwma
left a comment
schwma
left a comment
There was a problem hiding this comment.
Hi @lochlouw, thank you for your PR!
Could you please address the review comments?
Regarding the comment on the graphiql.test.js test suite, we were experiencing some Jest test concurrency issues which lead us to establish the pattern of only calling cds.test once per test suite. Therefore, please move your describe block into the root describe block, to use the same cds.test instance.
Additionally, an entry to the tbd section of the CHANGELOG.md would be helpful, if you would like to add one.
Thanks and best regards,
Marcel
schwma
requested changes
Jan 20, 2026
Member
schwma
left a comment
schwma
left a comment
There was a problem hiding this comment.
I noticed one more small thing in a test expect. Apart from that everything looks good!
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
schwma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphiQLlink to the service index HTML page for GraphQL endpoints, making it easier to access theGraphiQLinterface.closes #220