Skip to content

Conversation

@lorenzos
Copy link

An optional boolean parameter in renderWhenReady that renders Webamp inside the DOM node passed as first argument, and makes the positioning restricted inside of it.

I developed this by setting up a new Vite development server inside of examples/contained: this can be deleted, but I figured out it could be useful to leave there for reference, as an additional example.

@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for tourmaline-kringle-c98715 canceled.

Name Link
🔨 Latest commit 88464a0
🔍 Latest deploy log https://app.netlify.com/projects/tourmaline-kringle-c98715/deploys/694992e77403920008cf354d

@captbaritone
Copy link
Owner

This is fantastic! Probably the number one most requested feature for Webamp.

I'll try to find time for a more detailed review soon, but at a quick glance this looks broadly correct.

A few thoughts:

  1. Could you add documentation for this option?
  2. How feasible do you think it would be to actually place the Webamp windows as children of the provided parent, vs leaving Webamp as a direct child of the document but mathematically containing it. I think people are often surprised that Webamp is not a child of the provided DOM node and therefore things like CSS scoped to the container does not apply.

Thanks for working on this!

@lorenzos
Copy link
Author

I think I already did both! :)

@captbaritone
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants