feat: add onBackgroundRefreshFailed hook to AbstractUseStaleRequest#30
Merged
jwadhams merged 1 commit intoApr 17, 2026
Merged
Conversation
Replaces the silent catch block in the background refresh closure with a no-op hook method. Consumers can override onBackgroundRefreshFailed() to add logging or metrics without the library forcing a specific behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwadhams
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Adds an extensibility hook to
AbstractUseStaleRequestso consumers can observe background refresh failures without the library forcing specific behaviour.Technical Notes
The background refresh closure previously swallowed all
\Throwablesilently:The new no-op hook:
Consumers override
onBackgroundRefreshFailed()in their subclass or via a trait to add logging or metrics. The library itself stays behaviour-neutral.Corresponding Tickets
MR-7177
Checklist