Conversation
|
c7d4928 to
99990bf
Compare
99990bf to
508162f
Compare
bdada99 to
8e1e376
Compare
|
For me would be a solid yes. @endersonmaia there is some rebase to be done. cc: @tuler do you have any comments related to the change? |
|
On extra thing I did in the PR was to enable the trivy image scan for CVEs in the images built by the sdk package. The cartesi/sdk is failing because it has javascript projects inside that have CRITICAL/HIGH CVEs. We need to decide how to handle this. |
c82f9c2 to
8b4015b
Compare
By running |
The CVEs that this PR gets, is from the container images built in packages/sdk. So inside the cartesi/sdk image, there's nodejs build process at https://github.com/cartesi/cli/blob/feature/use-docker-hardened-images/packages/sdk/Dockerfile#L236-L239 I think |
You're right, it only checks our own monorepo. I run that because the failed build does not say much besides the return code 1. I could not see any report attachments or links to some result. Did I miss something? So you're saying that the problem is in building a third-party Another thing I briefly discussed with @tuler is replacing PS: Also, something to think about when we're moving to a stricter rule (i.e., using DHI) is that, since we use a lot of third parties we don't control, and if we can't loosen up a bit in certain situations, it may often become a blocker. |
They're on the Action Summary https://github.com/cartesi/cli/actions/runs/22623090609/attempts/1#summary-65555014961
I'll send a fixup with this bump.
I'll need help with that, since I don't know how to use/exercise the features provided by Alto/Rundler.
We have the power to rebase/merge anyway, after an approval. The CI job will make its job of alerting us. |
8b4015b to
0c1e2da
Compare
Thanks for pointing that out.
I am not saying to do that here. Just highlighting a conversation where an assessment was suggested in terms of if features we use on one match the other is more about which one has better maintenance. Also, I myself need to be acquainted with this piece and other parts of the CLI project.
Gotcha! It is more of an alert than a PR blocker, per se. |
0c1e2da to
cce5b3c
Compare
|
Did the alto bump on another PR #437 |
Using trivy to scan vulnerabilities in Docker images, we found that: BEFORE : Total: 139 (UNKNOWN: 4, LOW: 99, MEDIUM: 31, HIGH: 5, CRITICAL: 0) AFTER : Total: 78 (UNKNOWN: 5, LOW: 69, MEDIUM: 3, HIGH: 1, CRITICAL: 0)
Using trivy to scan vulnerabilities in Docker images, we found that: BEFORE: Total: 97 (UNKNOWN: 2, LOW: 82, MEDIUM: 13, HIGH: 0, CRITICAL: 0) AFTER : Total: 88 (UNKNOWN: 2, LOW: 76, MEDIUM: 10, HIGH: 0, CRITICAL: 0)
52d3113 to
5962012
Compare
This pull request updates the SDK's Docker build process and related configuration to improve image security and flexibility. The main changes include switching to hardened base images from a private registry, splitting PostgreSQL images into build and runtime variants, and refining the Dockerfile to streamline dependencies and user creation.
Container base image and registry updates:
dhi.iofor improved security (packages/sdk/docker-bake.hcl).dhi.io) before building images (.github/workflows/sdk.yaml).PostgreSQL image improvements:
dhi.iofor production, with configurable major version support (packages/sdk/docker-bake.hcl,packages/sdk/Dockerfile). [1] [2] [3]packages/sdk/Dockerfile).Dockerfile dependency and user management:
passwd), then remove them immediately after use to reduce image size and attack surface (packages/sdk/Dockerfile). [1] [2]lua5.4andxz-utilsfrom the runtime dependencies (packages/sdk/Dockerfile).Build process enhancements:
/usr/local/bindirectory exists before extracting binaries, improving reliability during the build (packages/sdk/Dockerfile).forgebinary is included, copying it from a prior build stage instead of downloading it again, which improves build caching and consistency (packages/sdk/Dockerfile).