Skip to content

Publish tax share analysis report and code#45

Merged
kyrasturgill merged 14 commits into
mainfrom
add-tax-share-analysis-files
Mar 31, 2026
Merged

Publish tax share analysis report and code#45
kyrasturgill merged 14 commits into
mainfrom
add-tax-share-analysis-files

Conversation

@kyrasturgill

Copy link
Copy Markdown
Member

This PR publishes 2025 Summer Intern's analysis on how residential share of the tax base translates to share of the tax burden. Both the quarto file containing the code and the final rendered report as an html file are included. The code pulls from the CCAO's Open Data, meaning anyone can replicate and render the report.

@kyrasturgill kyrasturgill requested a review from a team as a code owner March 17, 2026 21:20
@jeancochrane

Copy link
Copy Markdown
Member

@kyrasturgill I think the HTML linter is failing because it doesn't like some of the choices that Quarto makes when it autogenerates an HTML file with bundled dependencies. Since the HTML file is autogenerated, we should probably just configure superlinter to ignore it. Based on the docs, there seem to be two ways we can do this:

  1. The easiest way to exclude the file would be to add the following line to the env config of the superlinter workflow:
--- a/.github/workflows/lint.yaml
+++ b/.github/workflows/lint.yaml
@@ -30,3 +30,5 @@ jobs:
           DEFAULT_BRANCH: main
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           VALIDATE_SQLFLUFF: false
+          # Exclude autogenerated HTML files
+          FILTER_REGEX_EXCLUDE: ^analyses/tax-share-analysis/residential_tax_share_analysis_report.html$
  1. A harder but more technically correct way to ignore the file would be to tweak the Quarto doc so that it emits an HTML comment with the text @generated, but comment that line with @not-generated in the Quarto context so that superlinter will lint the Quarto doc but not the HTML doc.

2 is the right call but I bet it will be annoying and I'm not convinced it's worth the extra effort. I'm happy with 1 as the quick-and-dirty solution.

@ccao-jardine ccao-jardine left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the teamwork on this! I'm excited that more of our intern work is public! 🚀

ccing our Harris interns @mariefarhat who did the vast majority of this work, and @Rushikeshay whose onboarding task involved a copy edit.

@kyrasturgill kyrasturgill merged commit 523ae5e into main Mar 31, 2026
6 checks passed
@kyrasturgill kyrasturgill deleted the add-tax-share-analysis-files branch March 31, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants