Publish tax share analysis report and code#45
Merged
Conversation
Member
|
@kyrasturgill I think the HTML linter is failing because it doesn't like some of the choices that Quarto makes when it autogenerates an HTML file with bundled dependencies. Since the HTML file is autogenerated, we should probably just configure superlinter to ignore it. Based on the docs, there seem to be two ways we can do this:
--- a/.github/workflows/lint.yaml
+++ b/.github/workflows/lint.yaml
@@ -30,3 +30,5 @@ jobs:
DEFAULT_BRANCH: main
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VALIDATE_SQLFLUFF: false
+ # Exclude autogenerated HTML files
+ FILTER_REGEX_EXCLUDE: ^analyses/tax-share-analysis/residential_tax_share_analysis_report.html$
2 is the right call but I bet it will be annoying and I'm not convinced it's worth the extra effort. I'm happy with 1 as the quick-and-dirty solution. |
ccao-jardine
approved these changes
Mar 31, 2026
ccao-jardine
left a comment
Member
There was a problem hiding this comment.
Thanks for the teamwork on this! I'm excited that more of our intern work is public! 🚀
ccing our Harris interns @mariefarhat who did the vast majority of this work, and @Rushikeshay whose onboarding task involved a copy edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR publishes 2025 Summer Intern's analysis on how residential share of the tax base translates to share of the tax burden. Both the quarto file containing the code and the final rendered report as an html file are included. The code pulls from the CCAO's Open Data, meaning anyone can replicate and render the report.