fix: defer confirmation handling to resolve Windows event loop race condition#258
Merged
dwash96 merged 1 commit intocecli-dev:v0.90.0from Dec 15, 2025
Merged
Conversation
Author
|
So I've now ran into this command interception issue on macos as well. It'll prompt for the add file y/n/s and sometimes hitting that will send a "n" and trigger another exchange with the llm. I think this'll fix it (at least it appears to on my device) but worth getting another set of eyes on it. |
Collaborator
|
This probably also addresses #260, good looking out, merging into 0.90.0 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When confirm_ask requests input, it reuses the underlying io.input_task. Since Coder.input_task is also awaiting io.input_task, both tasks wake up when the user types a response.