[Small bug fix] benchmark stats by language - pull the correct pass rate for each language#32
Merged
dwash96 merged 4 commits intocecli-dev:v0.87.10from Oct 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! My previous PR #27 had a slight bug. When you run
benchmark.py --stats --verboseand view the stats broken down by language, It was using the wrong language to retrieve the pass rate.Apologies for the error. I did some last second refactoring before submitting the PR, and didn't catch this bug in my manual spot tests.
This small PR fixes the mentioned bug by passing in
langas a parameter to retrieve the correctnum_passedandpass_ratefor each language.