feat: normalize ContextManager tool arguments#346
Closed
chrisnestrud wants to merge 1 commit intocecli-dev:mainfrom
Closed
feat: normalize ContextManager tool arguments#346chrisnestrud wants to merge 1 commit intocecli-dev:mainfrom
chrisnestrud wants to merge 1 commit intocecli-dev:mainfrom
Conversation
- add helper to coerce remove/edit/view/create args into lists, accepting JSON strings, whitespace, or single paths - treat empty or whitespace-only strings as empty lists so validation still triggers when nothing is requested - cover parser behavior, error propagation, and the escaped quote regression with dedicated tests Rationale: recent tool calls emitted JSON-encoded lists like "[\"aider/coders/base_coder.py\"]", which the tool previously iterated character by character. Normalizing inputs prevents mis-parsing and preserves explicit error handling when no work is specified.
Collaborator
|
Ha, while working on the rename, I ran into this. I used your implementation to add a "parse_arg_as_list" method in the aider/tool/helpers.py file so this will be in the next version definitely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: recent tool calls emitted JSON-encoded lists like "["aider/coders/base_coder.py"]", which the tool previously iterated character by character. Normalizing inputs prevents mis-parsing and preserves explicit error handling when no work is specified.