Use config from celo's fork of superchain registry#426
Open
piersy wants to merge 2 commits intocelo-rebase-16from
Open
Use config from celo's fork of superchain registry#426piersy wants to merge 2 commits intocelo-rebase-16from
piersy wants to merge 2 commits intocelo-rebase-16from
Conversation
This version of op-geth embeds valid celo superchain config from our fork of the suprechain registry, this means we can get rid of our hardcoded config overrides.
Unfortunately we still need code changes in optimism to copy the cel2 field over into the rolup config defined in the optimism repo. Also we need to ignore the gingerbread block in a test, as it is only relevant for constructing the chain config in op-geth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates op-geth to use a version with correct celo superchain registry config.
Unfortunately we still need some code changes in optimism to copy the cel2
field over into the rollup.Config struct defined in the optimism repo.
Also we need to ignore the gingerbread block in a test, as it is only
relevant for constructing the chain config in op-geth.
But we do get to get rid of our original celo hardfork overrides.
Relates to - https://github.com/celo-org/celo-blockchain-planning/issues/1346