[ceph-make-check-periodic-ppc64] Added support for ppc64 runners#2492
[ceph-make-check-periodic-ppc64] Added support for ppc64 runners#2492anshuman-agarwala wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? |
anshuman-agarwala
force-pushed
the
power-support
branch
2 times, most recently
from
c7048b8 to
bed38a4
Compare
|
can we add in some details on why we are adding this in? also - do we have enough runners in the lab for this? |
I've added some detail on what this does in the description. |
anshuman-agarwala
force-pushed
the
power-support
branch
2 times, most recently
from
7402b9d to
a1acd92
Compare
|
thanks for the context.! can this be like a weekly job rather than a PR check? especially in the beginning while resources are flushed out (gear as well as effort to maintain this) |
anshuman-agarwala
force-pushed
the
power-support
branch
from
a1acd92 to
f50f393
Compare
|
Sure! I've changed the job cadence to weekly. |
anshuman-agarwala
force-pushed
the
power-support
branch
from
f50f393 to
4e22049
Compare
anshuman-agarwala
changed the title
| # echo '===== npm cache info =======' | ||
| # du -sh "${NPMCACHE}" || echo "${NPMCACHE} not present" | ||
| # echo '============================' | ||
| #} |
There was a problem hiding this comment.
I'd suggest removing the commented bits
There was a problem hiding this comment.
I've removed the commented code
| "${@}" | ||
| } | ||
|
|
||
| podman login -u ${DOCKER_HUB_USERNAME} -p ${DOCKER_HUB_PASSWORD} docker.io |
There was a problem hiding this comment.
I think the default centos-9 image is being pulled from dockerhub when I run this script.
| # echo "Warning: Attempt $((i + 1)) to cache npm packages failed." | ||
| # sleep $((10 + 30 * i)) | ||
| #done | ||
| #npm_cache_info |
There was a problem hiding this comment.
I'd suggest removing the rest of the commented bits here as well
| # manually after the job is aborted. | ||
|
|
||
| # if ctest is still running, get its pid, otherwise we are done. | ||
| ctest_pid=$(pgrep ctest) || exit 0 |
There was a problem hiding this comment.
won't this potentially kill other runs on the same machine since concurrent: true is set in the job config?
There was a problem hiding this comment.
This is how we're doing it for the x86/arm jobs:
Anyways it should not matter here since the power runners won't have any other jobs running on them right now.
| node: 'ppc64 && (installed-os-noble || centos9)' | ||
| parameters: | ||
| - string: | ||
| name: ghprbPullId |
There was a problem hiding this comment.
I would suggest renaming this parameter since the (deprecated) ghprb plugin isn't being used here
There was a problem hiding this comment.
I've renamed this parameter.
| num-to-keep: 300 | ||
| - raw: | ||
| xml: | | ||
| <com.sonyericsson.jenkins.plugins.bfa.model.ScannerJobProperty plugin="build-failure-analyzer@1.18.1"> |
There was a problem hiding this comment.
is this section necessary? I haven't seen this done before.
I am also a little concerned about the hardcoding of the plugin version.
There was a problem hiding this comment.
I don't recall why I added this. I'm looking at corresponding x86 and arm jobs and they don't seem to have this. I've removed both these sections.
| url: https://github.com/ceph/ceph/ | ||
| - raw: | ||
| xml: | | ||
| <com.sonyericsson.rebuild.RebuildSettings plugin="rebuild@1.25"> |
There was a problem hiding this comment.
I've removed this.
Signed-off-by: Anshuman <anshuman@ibm.com>
anshuman-agarwala
force-pushed
the
power-support
branch
from
4e22049 to
2a1cebf
Compare
4 participants
This PR adds support for running
make checkjob on Power hardware.