helm: add PodMonitor support to ceph-csi-rbd Helm chart#6287
Conversation
Signed-off-by: nepomucen <szymon@aus.krakow.pl>
|
@jd would you be so kind and review my PR. This is something we have been patching ever since with |
Not really my thing, sorry. |
|
This is quite nice and simple. But the Helm Charts are being deprecated (slowly), and replaced by Ceph-CSI Operator. It probably makes sense to add (optional) support for PodMonitor to Ceph-CSI Operator instead. Is there a good reason to only add it for provisioners, and not the node-plugins? PodMonitor should be added to other storage types too. |
Describe what this PR does
This pull request adds support for monitoring the provisioner component of the Ceph-CSI RBD Helm chart via Prometheus by introducing an optional
PodMonitorresource.This enables users to easily integrate metrics collection for the provisioner and its sidecars when Prometheus Operator is installed.
provisioner.podMonitor.enabled=falseChecklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)