rbd: update cgroup v2 QoS support for krbd#6343
Open
Madhu-1 wants to merge 4 commits into
Open
Conversation
Replace /proc/partitions parsing with syscall to obtain the device major:minor number. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Replace the systemd-only cgroup path lookup with a candidate-based approach that probes both systemd and cgroupfs driver layouts. The new podCgroupCandidates function generates paths for all three QoS classes under each driver, and f indPodCgroupPath now checks for the io.max file directly rather than just the directory existence. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
when the found mounter is ErrMounterUnknown log the warning saying the qos will be applied only when krbd is used to mount the volume. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Add validateIOMax helper that verifies the io.max file on the node contains the correct device ID and QoS values after cgroup QoS is applied. The validation runs inside the csi-rbdplugin daemonset pod which has /sys host-mounted, probing both systemd and cgroupfs cgroup driver layouts. All three cgroup QoS scenarios (RWO filesystem, RWO block, RWOP) now validate io.max content after the app pod is created. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Collaborator
Author
|
/test ci/centos/mini-e2e/k8s-1.35/rbd |
YiteGu
approved these changes
Jun 18, 2026
Rakshith-R
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unix.Statsyscall to obtain device major:minor instead of parsing/proc/partitions