csi: watch VGRC metadata to reduce memory usage#6345
Conversation
black-dragon74
left a comment
There was a problem hiding this comment.
You need to add VRGC to:
ceph-csi/internal/controller/controller.go
Lines 85 to 88 in 62342db
If missing, a duplicate cache will be created on Get()
cf42844 to
f09f774
Compare
|
@Mergifyio rebase |
🛑 The pull request rule doesn't match anymoreDetailsThis action has been cancelled. |
|
Queued — the merge queue status continues in this comment ↓. |
|
Deprecation notice: This pull request comes from a fork and was queued with |
Merge Queue Status
This pull request spent 34 minutes 47 seconds in the queue, including 34 minutes 10 seconds running CI. Required conditions to merge
|
Use WatchesMetadata instead of caching full VolumeGroupReplicationContent objects in the informer cache. This reduces memory consumption in clusters with many VGRC objects by only caching object metadata. Also adds a delete event predicate filter to skip unnecessary reconciliation for objects being deleted. Signed-off-by: Praveen M <m.praveen@ibm.com>
f09f774 to
1749f47
Compare
Describe what this PR does
Use WatchesMetadata instead of caching full VolumeGroupReplicationContent objects in the informer cache. This reduces memory consumption in clusters with many VGRC objects by only caching object metadata.
Also adds a delete event predicate filter to skip unnecessary reconciliation for objects being deleted.
Fixes: #5414
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)