Skip to content

csi: watch VGRC metadata to reduce memory usage#6345

Merged
mergify[bot] merged 1 commit into
ceph:develfrom
iPraveenParihar:vgrc-metadata-watch
Jun 23, 2026
Merged

csi: watch VGRC metadata to reduce memory usage#6345
mergify[bot] merged 1 commit into
ceph:develfrom
iPraveenParihar:vgrc-metadata-watch

Conversation

@iPraveenParihar

Copy link
Copy Markdown
Contributor

Describe what this PR does

Use WatchesMetadata instead of caching full VolumeGroupReplicationContent objects in the informer cache. This reduces memory consumption in clusters with many VGRC objects by only caching object metadata.

Also adds a delete event predicate filter to skip unnecessary reconciliation for objects being deleted.

Fixes: #5414

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar marked this pull request as ready for review June 17, 2026 11:59

@black-dragon74 black-dragon74 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add VRGC to:

DisableFor: []client.Object{
&corev1.PersistentVolume{},
&corev1.Secret{},
},

If missing, a duplicate cache will be created on Get()

@iPraveenParihar iPraveenParihar added the ci/skip/e2e skip running e2e CI jobs label Jun 23, 2026
@iPraveenParihar

Copy link
Copy Markdown
Contributor Author

@Mergifyio rebase

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

rebase

🛑 The pull request rule doesn't match anymore

Details

This action has been cancelled.

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Deprecation notice: This pull request comes from a fork and was queued with update_method=rebase and update_bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the merge queue will no longer be able to rebase fork pull requests with this configuration. To avoid disruption, switch to update_method=merge in your queue rule.

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-06-23 03:59 UTC · Rule: default · triggered by merge protections
  • Checks passed · in-place
  • Merged2026-06-23 04:34 UTC · at 1749f471c1d4d7fd7c411a4937c66dad4162504a · rebase

This pull request spent 34 minutes 47 seconds in the queue, including 34 minutes 10 seconds running CI.

Required conditions to merge

Use WatchesMetadata instead of caching full
VolumeGroupReplicationContent objects in the informer cache.
This reduces memory consumption in clusters with many VGRC
objects by only caching object metadata.

Also adds a delete event predicate filter to skip unnecessary
reconciliation for objects being deleted.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@ceph-csi-bot ceph-csi-bot force-pushed the vgrc-metadata-watch branch from f09f774 to 1749f47 Compare June 23, 2026 03:59
@mergify mergify Bot added the queued label Jun 23, 2026
@mergify mergify Bot merged commit f6b6846 into ceph:devel Jun 23, 2026
19 checks passed
@mergify mergify Bot removed the queued label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/skip/e2e skip running e2e CI jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvise the PV/VGRC controller

3 participants