Update Layout #585
Open
flacoman91 wants to merge 3 commits into
Open
Conversation
flacoman91
requested review from
anselmbradford,
billhimmelsbach,
contolini and
natalia-fitzgerald
as code owners
flacoman91
changed the title
|
flacoman91
force-pushed
the
rad-layout-only
branch
2 times, most recently
from
d3102b1 to
6922bca
Compare
Collaborator
|
@flacoman91 |
flacoman91
force-pushed
the
rad-layout-only
branch
from
6922bca to
ae8dd5d
Compare
Collaborator
Author
I updated the original details. The motivation for this fix was the complaint detail page in which the divider line wouldn't grow match whatever was the longer content column, sidebar or main. |
flacoman91
force-pushed
the
rad-layout-only
branch
from
b7e8b41 to
4e36082
Compare
natalia-fitzgerald
requested changes
May 21, 2026
Collaborator
natalia-fitzgerald
left a comment
natalia-fitzgerald
left a comment
There was a problem hiding this comment.
@flacoman91
Can we make the following changes to the Storybook pages within Layout? I have made suggestions about the content but feel free to tweak if you have improvements.
Are the code examples for each of these, content, main, sidebar, and wrapper duplicative?
- Change "Layout" to "Layouts"
Content
- Change "Content" body text to: "Content is the main body of the page, situated between the header and the footer."
- Change labeling of example to "Content" and "Sidebar" instead of "Content.Sidebar" and "Layout.Sidebar"
- Remove "Usage" section
- Update to match the screenshot below:
Main
- Change "Main" body text to: "Main is the container for all of the content within a layout. It is used to configure the column structure and whether the sidebar bleeds to the window edge."
- Change labeling of example to "Content" and "Sidebar" instead of "Content.Sidebar" and "Layout.Sidebar"
- Remove "Usage" section
- Update to match the screenshot below:
Sidebar
- Change "Sidebar" body text to "A sidebar is a vertical user interface element positioned on the left or right side of the main content area."
- Change labeling of example to "Content" and "Sidebar" instead of "Content.Sidebar" and "Layout.Sidebar"
- Remove "Usage" section
- Update to match the screenshot below:
Wrapper
- Change "Wrapper" body text to "The wrapper serves as a container for other components or elements. It wraps around child components and provides additional functionality, such as styling, context, or logic."
- Change labeling of example to "Content" and "Sidebar" instead of "Content.Sidebar" and "Layout.Sidebar"
- Remove "Usage" section
- Update to match the screenshot below:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking layout work out of #560 to have a more focused PR
Update the layout component