Add spanish logo to header component#594
Merged
Merged
Conversation
flacoman91
requested review from
anselmbradford,
billhimmelsbach,
contolini and
natalia-fitzgerald
as code owners
|
Collaborator
|
I think this will get fixed when we merge #582 but it looks like the extra top and bottom 10px of padding are showing up here. Also, for the Spanish we'll have to have it so that turning on the Spanish logo also switches the US gov banner to the Spanish version. The text for that should be "Un sitio web oficial del gobierno federal de los Estados Unidos". While we're at it we should add this to the US gov banner component too. |
…-svg # Conflicts: # src/components/Header/header.test.tsx # src/components/Header/header.tsx
update description
natalia-fitzgerald
approved these changes
May 20, 2026
Collaborator
natalia-fitzgerald
left a comment
natalia-fitzgerald
left a comment
There was a problem hiding this comment.
@flacoman91 - Looks great! Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
langparameter to acceptenoresto display the different logo, English or SpanishTo test:
https://cfpb.github.io/design-system-react/pr-previews/pr-594/?path=/story/components-draft-header--default&args=lang:es