update Hero image file paths#2689
Merged
Merged
Conversation
Contributor
natalia-fitzgerald
left a comment
There was a problem hiding this comment.
@flacoman91
If possible it would probably be more stable to store the images within the CFPB Design System instead of linking to an image on cf.gov. That way if the hero image changes on cf.gov it doesn't affect the DS.
Contributor
Author
|
Renaming file paths may break any other sites that are pointing to the existing images. |
natalia-fitzgerald
approved these changes
May 28, 2026
Contributor
natalia-fitzgerald
left a comment
There was a problem hiding this comment.
@flacoman91
Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since DSR references DS documentation and directly points to the images used, we want to update the image at the source
See cfpb/design-system-react#597 (comment)
Additions
Notes:
I noticed that for the flag background image in the Hero, it directly links to http://files.consumerfinance.gov/f/images/PC_hero.original.jpg
For consistency, we should do one of the following:
I went ahead and brought the flag image into the repo, and also updated all of the paths for the example documentation to point to the relative paths instead of hardcoding it to cfpb.github.io. This matches the Jumbo and 50/50 hero examples in how they serve up the images
Renamed the images used to match the hero variant that uses it:
Screenshots