Skip to content

update Hero image file paths#2689

Merged
flacoman91 merged 5 commits into
mainfrom
rad-update-hero-image
May 28, 2026
Merged

update Hero image file paths#2689
flacoman91 merged 5 commits into
mainfrom
rad-update-hero-image

Conversation

@flacoman91
Copy link
Copy Markdown
Contributor

@flacoman91 flacoman91 commented May 27, 2026

Since DSR references DS documentation and directly points to the images used, we want to update the image at the source

See cfpb/design-system-react#597 (comment)

Additions

Notes:

I noticed that for the flag background image in the Hero, it directly links to http://files.consumerfinance.gov/f/images/PC_hero.original.jpg

For consistency, we should do one of the following:

  1. direct link the knockout hero image to the consumer market trends (files.consumerfinance.gov) to match the flag image
  2. bring in that flag image into this repo and update the example images to point to the file on cfpb.github.io

I went ahead and brought the flag image into the repo, and also updated all of the paths for the example documentation to point to the relative paths instead of hardcoding it to cfpb.github.io. This matches the Jumbo and 50/50 hero examples in how they serve up the images

Renamed the images used to match the hero variant that uses it:

  • design_system_knockout_hero_example.png
  • design_system_photo_hero_example.png
  • design_system_illustration_hero_example.png
  • design_system_jumbo_hero_example.png
  • design_system_50-50_hero_example.png

Screenshots

Screenshot 2026-05-28 at 12 55 27 PM Screenshot 2026-05-28 at 12 55 21 PM Screenshot 2026-05-28 at 12 55 13 PM

Copy link
Copy Markdown
Contributor

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flacoman91
If possible it would probably be more stable to store the images within the CFPB Design System instead of linking to an image on cf.gov. That way if the hero image changes on cf.gov it doesn't affect the DS.

@flacoman91 flacoman91 changed the title update knockout hero image update Hero image file paths May 28, 2026
@flacoman91 flacoman91 marked this pull request as draft May 28, 2026 15:29
@flacoman91
Copy link
Copy Markdown
Contributor Author

Renaming file paths may break any other sites that are pointing to the existing images.

@flacoman91 flacoman91 marked this pull request as ready for review May 28, 2026 20:05
@natalia-fitzgerald natalia-fitzgerald self-requested a review May 28, 2026 20:11
Copy link
Copy Markdown
Contributor

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flacoman91
Looks good!

@flacoman91 flacoman91 merged commit d60a16b into main May 28, 2026
3 checks passed
@flacoman91 flacoman91 deleted the rad-update-hero-image branch May 28, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants