[components] Migrate seven small components to Composition API - #2208
Merged
frankrousseau merged 8 commits intoSep 14, 2026
Merged
frankrousseau merged 8 commits into
frankrousseau merged 8 commits into
Conversation
Convert the asset list footer to script setup on top of useFormat, in place of formatListMixin. The hours or days label branches now only pick the i18n key. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Convert PeopleQuotaInfo to script setup. Its close method and close emit were never called, the panel closes through its router link, so drop them along with the listener on the quota page. The week bounds share one moment instance, the close route keeps production_id in its params, and the root class no longer carries the timesheet panel name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Drop state that was written but never read (isLoading, currentMode), the unused template refs and two dead CSS rules. The silent route query reset and the shot reload, each duplicated across two watchers, move to one method apiece. Imports follow the project order. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Convert PeopleList to script setup. useGrabList replaces the dom and grab list mixins and manages the document listeners. The users label key, built twice for the header and the footer, is shared, and a mobile icon margin that never applied is dropped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Convert Brief to script setup: the client redirect moves to onMounted and the title to useHead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Convert TimelineItem to script setup with typed props and defaults. Drop the is-completed title rules, which repeated the base colors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Convert EntityPreviewFileCard to script setup. Drop the unused task type helper and its store getters, the empty mounted hook and the root key the parent already sets. The download path becomes a computed, and two no-op CSS declarations go. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
Convert ProductionAssetTypes to script setup. The search mixin is dropped: its route watcher did nothing on this page, and the two URL helpers the page used are inlined. The CSV export passes the count mode it already fell back to, and the title no longer throws before the production loads. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8vdEJjSK2MsTYP3TVX6a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
<script setup>, using useFormat and useGrabList.