feat(rbac): allow creating orgs to tokens with proper permissions#2703
Merged
jiparis merged 6 commits intochainloop-dev:mainfrom Feb 5, 2026
Merged
feat(rbac): allow creating orgs to tokens with proper permissions#2703jiparis merged 6 commits intochainloop-dev:mainfrom
jiparis merged 6 commits intochainloop-dev:mainfrom
Conversation
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
javirln
previously approved these changes
Feb 4, 2026
migmartri
reviewed
Feb 4, 2026
Member
migmartri
left a comment
There was a problem hiding this comment.
Added some comments, I'd like to get some understanding on what's the expected behavior of the org create with both token/users and restrictedCreation/non-restricted
migmartri
requested changes
Feb 4, 2026
Member
migmartri
left a comment
There was a problem hiding this comment.
Please double check my comments
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Feb 4, 2026
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Member
Author
I've updated the description with some tests with and without restrict_org_description setting |
migmartri
approved these changes
Feb 5, 2026
| // Restricted org creation is disabled, allow creation | ||
| if !s.authz.RestrictOrgCreation { | ||
| // if org creation restriction is disabled, allow creation to all users | ||
| if !s.authz.RestrictOrgCreation && entities.CurrentUser(ctx) != nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for tokens to create organizations, if they have the "organization:create" policy associated.
I've removed the ad hoc permissions check that this endpoint used to have, and replaced with policy checks, both for users and API tokens.
See some execution logs:
With
restrict_org_creation: false:regular user (Instance Admin): allowed 🟢
regular user (Org Viewer in another org): allowed 🟢
regular API token in a different org: not allowed 🔴
Instance Admin API token: allowed 🟢
With
restrict_org_creation: true:regular user (Instance admin): allowed 🟢
regular user (Org viewer in different org): not allowed 🔴
regular API token from existing org: not allowed 🔴
Instance admin API token: allowed 🟢
Closes #2704