Add stategic metadata to insert_submission, SubmissionCompleted and SubmissionFailed#58
Add stategic metadata to insert_submission, SubmissionCompleted and SubmissionFailed#58
Conversation
jerbaroo
changed the title
Qqwy
left a comment
Qqwy
left a comment
There was a problem hiding this comment.
Hey Jeremy! A very nice PR so far. The one request I have is that you add a test for both of the cases (to the Python test suite).
jerbaroo
force-pushed
the
jerbaroo-42
branch
3 times, most recently
from
aa4f7ba to
d5db03b
Compare
jerbaroo
force-pushed
the
jerbaroo-42
branch
2 times, most recently
from
42a9a61 to
8486574
Compare
jerbaroo
force-pushed
the
jerbaroo-42
branch
from
8486574 to
ac3e448
Compare
| serialization_format: SerializationFormat = DEFAULT_SERIALIZATION_FORMAT, | ||
| metadata: None | bytes = None, | ||
| strategic_metadata: None | dict[str, str | int] = None, | ||
| strategic_metadata: None | dict[str, int] = None, |
There was a problem hiding this comment.
These were adjusted during testing, since attempting to pass something of type dict[str, str] produced the following run-time type error TypeError: argument 'strategic_metadata': 'str' object cannot be interpreted as an integer, which seems to stem from the underlying rust definition of strategic metadata which does not support strings as values:
opsqueue/opsqueue/src/common/mod.rs
Line 14 in e823308
There was a problem hiding this comment.
Yes. It's indeed the case that currently only ints are supported.
If it still gives you problems, I guess the actual appropriate Python type to use here would be Mapping[str, int] (the immutable version of dict), which matters because of variance.
2 participants
Add stategic metadata as a parameter to
insert_submission(which just passes it toinsert_submission_chunks), and make the strategic metadata available in the submission results:SubmissionCompletedandSubmissionFailed.