Open
Conversation
slm960323
commented
Jan 26, 2022
slm960323
commented
- Remove cffi from the github action autotest
- Add task-bench to auto test
- Add local_msg test file
- Local_msg test failed with the current master
Contributor
|
We should document that we are moving away from the CFFI and Ctypes backends, with Cython being the supported backend moving forward. |
Author
|
Charm4Py is trying to move away from cffi and use the Cython as the default. |
rbuch
requested changes
Jan 26, 2022
Contributor
rbuch
left a comment
rbuch
left a comment
There was a problem hiding this comment.
These changes seem unrelated to each other, perhaps they should be different, more descriptive commits?
| export PYTHONPATH="$PWD" | ||
| - name: test-charm4py | ||
| run: | | ||
| git clone https://github.com/slm960323/task-bench.git |
Contributor
There was a problem hiding this comment.
If this repo should be used in CI, it should be under the UIUC-PPL organization or made part of the charm4py repo, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.