Skip to content

Release 2.8.0 - #98

Merged
ali-farhadi-cko merged 4 commits into
mainfrom
release/2.8.0
Oct 6, 2026
Merged

ali-farhadi-cko merged 4 commits into
mainfrom
release/2.8.0

Conversation

@ali-farhadi-cko

Copy link
Copy Markdown
Contributor

Automated release of CheckoutComponentsSDK 2.8.0

Changelog

  • [ADDED] Saved cards with RememberMe in Flow
  • [ADDED] Remember Me account lookup by prefilled phone number
  • [UPDATED] Risk SDK version to 6.0.1

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:2019>250

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 18


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope — 2019>250 classifying §2.1 M8 More than 250 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🟠 Advisory review: Concerns worth a look

This PR needs a human approval. Before you give it, these are the things I'd want resolved.

This release bumps the SDK to 2.8.0 and adds saved-cards-with-RememberMe support in the sample app. Two concrete issues need resolution before approving.

Concerns

  • CHANGELOG.md has an orphan '##' separator between the 2.8.0 and 2.7.0 entries (line ~16), which is a formatting artifact that will render as a stray horizontal rule in every changelog viewer.
  • CHANGELOG.md release date for 2.8.0 is '06.10.2026' — this is a future date (and 2.7.0 is dated '24.09.2026'), so either the date format is wrong (DD.MM.YYYY vs MM.DD.YYYY) or both entries were given incorrect dates.
  • Package.swift changes the Risk SDK dependency from from: "4.0.1" (any version ≥ 4.0.1) to exact: "6.0.1" — this is a major-version jump of 2 with a breaking constraint; the reviewer should confirm the binary xcframework checksums were generated against a build that actually used Risk SDK 6.0.1 and that this major bump is intentional.
  • SampleApplication/Release-SPM-File/Package.swift uses from: "6.0.1" (semver-open) while the main Package.swift uses exact: "6.0.1" (pinned) — the two manifests have diverging resolution strategies for the same dependency, which could cause the sample app to resolve a different Risk SDK version than the released framework was built against.
  • The sdkChecksum in SampleApplication/Release-SPM-File/Package.swift (b1d3d123...) differs from the main Package.swift sdkChecksum (f473d4fb...) — this is expected if they point to different binaries, but it should be verified that the sample-app release file checksum matches the artifact it actually downloads.
  • test_applyLaunchConfig_explicitEmptyCustomerFields_overridesDefaults asserts that passing empty strings clears defaults, but applyCustomerSettings in LaunchConfigHydrator.swift applies customer fields unconditionally (no empty-string guard), meaning this is already the implemented behaviour — the test is valid, but the reviewer should confirm the intent is to clear defaults on empty string, not treat empty string as 'not provided'.

⚠️ The diff was too large to read in full, so this review covers only part of the change.


This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:2021>250

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 18


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope — 2021>250 classifying §2.1 M8 More than 250 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:2048>250

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 18


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope — 2048>250 classifying §2.1 M8 More than 250 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:2048>250

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 18


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope — 2048>250 classifying §2.1 M8 More than 250 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@ali-farhadi-cko
ali-farhadi-cko merged commit fdb5c6f into main Oct 6, 2026
2 of 4 checks passed
@ali-farhadi-cko
ali-farhadi-cko deleted the release/2.8.0 branch October 6, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants