Skip to content

docs(issuing): document card control responses - #471

Open
armando-rodriguez-cko wants to merge 1 commit into
masterfrom
fix/INT-1704-issuing-control-limit-responses
Open

armando-rodriguez-cko wants to merge 1 commit into
masterfrom
fix/INT-1704-issuing-control-limit-responses

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
Documents the issuing card control responses against the API reference and fixes the return documentation of the card control methods, which all described a card response.

Changes

  • src/api/issuing/controls.js: JSDoc typedefs for the control response (base fields, the velocity, mcc and mid subtypes, amount_remaining, is_editable), the list and the delete responses; @return corrected on the five card control methods
  • test/issuing/controls/controls-unit.js: one unit test per update subtype (velocity, mcc, mid) with the API reference example, asserting every field

API Reference

  • PUT /issuing/controls/{controlId} (update-control-response and its subtypes)
  • GET /issuing/controls/{controlId}, GET /issuing/controls, POST /issuing/controls, DELETE /issuing/controls/{controlId}

Breaking changes
None.

README
No change needed.

@agent-wall-e

agent-wall-e Bot commented Oct 8, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The diff contains only JSDoc type definitions and corrected @return annotations in existing source files, plus new unit tests — no runtime logic, endpoints, auth, persistence, or external integrations are added or changed.

Operational gates

  • ✅ jira_ticket (INT-1704)
  • ✅ independent_review

Files analysed: 2


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 8, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The diff contains only JSDoc type definitions and corrected @return annotations in existing source files, plus new unit tests — no runtime logic, endpoints, auth, persistence, or external integrations are added or changed. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team October 8, 2026 13:42
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR only adds JSDoc typedefs and corrects @return annotations in existing source files plus adds unit tests, introducing no new code paths, endpoints, persisted data, auth changes, or external integrations.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants