Repository navigation
docs(issuing): document card control responses - #471
Open
armando-rodriguez-cko wants to merge 1 commit into
Open
armando-rodriguez-cko wants to merge 1 commit into
armando-rodriguez-cko wants to merge 1 commit into
Conversation
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 2 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The PR only adds JSDoc typedefs and corrects @return annotations in existing source files plus adds unit tests, introducing no new code paths, endpoints, persisted data, auth changes, or external integrations.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…
david-ruiz-cko
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Documents the issuing card control responses against the API reference and fixes the return documentation of the card control methods, which all described a card response.
Changes
src/api/issuing/controls.js: JSDoc typedefs for the control response (base fields, the velocity, mcc and mid subtypes,amount_remaining,is_editable), the list and the delete responses;@returncorrected on the five card control methodstest/issuing/controls/controls-unit.js: one unit test per update subtype (velocity, mcc, mid) with the API reference example, asserting every fieldAPI Reference
PUT /issuing/controls/{controlId}(update-control-response and its subtypes)GET /issuing/controls/{controlId},GET /issuing/controls,POST /issuing/controls,DELETE /issuing/controls/{controlId}Breaking changes
None.
README
No change needed.