Support upgrading of CINC Client

[mrswadge]

Description

The directory name is incorrect when upgrading CINC. This change fixes the path.

This change is coupled with chef/mixlib-install#389.

Related Issues

#228
chef/mixlib-install#339
#249

Check List

• All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• New functionality includes testing.
• New functionality has been documented in the README if applicable
• All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[mrswadge]

Each time I sign off the commit, it's adding a new merge remote commit. Any idea how to stop that?

[dkowis]

I would super like to have cinc-client upgrades work :D

[mrswadge]

The issue affects very old cinc-client versions (we're on 15.6.10 and upgrading to 18.3.0), so the maintainers opted not to take the changes, which is their decision.

If you take the code changes I have suggested in this PR and also the mixlib changes mentioned too, then the upgrade can work. I've put my custom mixlib into an artifactory instance and so that's been enough for me to make progress.

[dkowis]

Oh that's interesting. I'm on cinc-client 18.3.0 and it didn't cooperate. I got the same error from #249 and I thought this was still the solution... Maybe it's not related to this, but more on that other one.

[mrswadge]

There is a product matrix in mixlib that needed updating to add cinc which is what my pull request to mixlib added:
chef/mixlib-install#389

See this specifically:
https://github.com/chef/mixlib-install/pull/389/files#diff-860efd9d5bfa21f0570091e1f7311509857b47def4905b6c8f76b283950f2a8cR50