Feature/filter data#15
Open
dfortem wants to merge 11 commits intocheminfo:mainfrom
Open
Conversation
added 7 commits
October 4, 2018 11:36
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
===========================================
- Coverage 93.04% 17.39% -75.66%
===========================================
Files 5 5
Lines 230 299 +69
Branches 40 57 +17
===========================================
- Hits 214 52 -162
- Misses 16 247 +231
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to allow the user to read only a partial amount of the data variable instead of reading it all first and filter later.
There are 2 solutions to do so:
Either you read consequent data and then you just Slice the variable data:
getDataVariableSlice(variableName, startIndex, size)Or you filter according to all dimensions:
getDataVariableFiltered(variableName, positionX, sizeX, positionY, sizeY...)I also added some tests.