Fix en passant not set when parsing PGN via Game.make(move:from:) - #78
Open
mirkoleardini wants to merge 2 commits into
Open
Fix en passant not set when parsing PGN via Game.make(move:from:)#78mirkoleardini wants to merge 2 commits into
mirkoleardini wants to merge 2 commits into
Conversation
Game.make(move:from:) was not updating enPassant on the new position when a pawn advanced two squares. This caused the subsequent position to have no knowledge of the en passant possibility, making SANParser fail to find a legal pawn capture (e.g. cxd6) and throwing PGNParser.Error.invalidMove. Board.move() handled this correctly — Game.make() now mirrors that behavior by setting enPassant and enPassantIsPossible when a pawn moves two squares, and clearing them otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game.make(move:from:) was not updating enPassant on the new position when a pawn advanced two squares. This caused the subsequent position to have no knowledge of the en passant possibility, making SANParser fail to find a legal pawn capture (e.g. cxd6) and throwing PGNParser.Error.invalidMove.
Board.move() handled this correctly — Game.make() now mirrors that behavior by setting enPassant and enPassantIsPossible when a pawn moves two squares, and clearing them otherwise.