Skip to content

Updated styling of the tooltip inner TouchableHighlight to fill the size of the tooltip container #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated styling of the tooltip inner TouchableHighlight to fill the size of the tooltip container #11

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2afcd21
Updated styling of the tooltip inner TouchableHighlight to fill the t…
Apr 14, 2016
64de768
Fixed typo
Apr 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ToolTip.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ var ViewClass = React.createClass({
} else {
props.onPress = this.showMenu;
}

// Override the style for the touchable highlight to fill the size of the tooltip container.
props.style = {
flex: 1,
alignSelf: 'stretch'
};

return props;
},
Expand All @@ -64,7 +70,7 @@ var ViewClass = React.createClass({

render: function() {
return (
<RCTToolTipText ref='toolTipText' onChange={this.handleToolTipTextChange}>
<RCTToolTipText ref='toolTipText' onChange={this.handleToolTipTextChange} style={this.props.style}>>
Copy link
Collaborator

@jrichardlai jrichardlai Apr 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is syntax error here

Copy link
Author

@msftsvachon msftsvachon Apr 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, copy/paste error. Fixed.

<TouchableHighlight
{...this.getTouchableHighlightProps()}
>
Expand Down