Update to 1.24 and use build-in version of tools command#3
Merged
Conversation
There was a problem hiding this comment.
PR Overview
This PR updates the project to Go 1.24 by switching to the built-in version of the counterfeiter tool and removing the now-unnecessary tools.go file.
- Updated the go:generate commands in pkg/midi/opener.go and pkg/midi/out.go to use "go tool counterfeiter".
- Removed tools.go since Go 1.24 now supports the tools pattern officially.
Changes
| File | Description |
|---|---|
| pkg/midi/opener.go | Updated counterfeiter command to use the built-in tool from Go 1.24. |
| pkg/midi/out.go | Updated counterfeiter command to use the built-in tool from Go 1.24. |
| tools.go | Removed since the built-in tools support in Go 1.24 makes it redundant. |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.