[Quality Review] [PXT-970 + PXT-1074] Gemini video reference images, TTS, and transcription - #19
Open
Chrisclone wants to merge 1 commit into
Open
Conversation
- Fix generate_videos docstring example: `image=` -> `images=` (wrong param name) - Fix transcribe docstring example: add missing required `prompt` param - Fix generate_speech docstring: remove `voices` param docs from base signature (belongs only on the multi-speaker overload) - Extract _extract_tts_audio() and _write_wav() helpers to eliminate duplicated WAV writing logic between generate_speech and its multi-speaker overload - Replace `assert video_bytes is not None` with proper excs.Error in _generate_videos_impl (assert is stripped by python -O) - Add null guard on transcribe response.text (Gemini can return None when the response is filtered) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Quality Review
Quality review of upstream PR #1221.
Process
Changes
1 file changed, 41 insertions(+), 39 deletions(-)
Please review and merge into your
geminibranch if the improvements look correct.Generated by OpenClaw Quality Review Pipeline