Add Enable/Disable All Bands menu item to filter drag overlay context… - #1016
Open
davidhealey wants to merge 2 commits into
Open
Add Enable/Disable All Bands menu item to filter drag overlay context…#1016davidhealey wants to merge 2 commits into
davidhealey wants to merge 2 commits into
Conversation
… menu Adds a toggle item alongside Delete all bands that enables or disables every band in one action, labeled based on current state.
FilterGraph::enableBand only called repaint(), which redraws the cached path without recomputing it. refreshFilterPath() is what actually rebuilds the trace based on each band's enabled state, so the curve stayed stale until something else (e.g. dragging a band) triggered a recompute. Call refreshAsync() instead, matching every other mutator that affects the drawn curve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… menu
Adds a toggle item alongside Delete all bands that enables or disables every band in one action, labeled based on current state.