Improve validation of jobs that run a SQL query#1
Open
lempiraholio wants to merge 1 commit intochristyharagan:masterfrom
Open
Improve validation of jobs that run a SQL query#1lempiraholio wants to merge 1 commit intochristyharagan:masterfrom
lempiraholio wants to merge 1 commit intochristyharagan:masterfrom
Conversation
The status of a job that is not `RUNNING` is not necessarily a failed job. (According to the API reference)[https://docs.dremio.com/rest-api/jobs/get-job.html#jobstatus-response-output] a job can have several status that are not `FAILED` (or `CANCELLED`) that do not throw an error message. The current validation of the status of the job only checks if the job is not in `RUNNING` nor it is a `COMPLETED` job and throws and error if so, but if for some reason the job is in `PENDING` or any other status that doesn't represent a failed job it will throw an error with an empty message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status of a job that is not
RUNNINGis not necessarily a failed job. According to the API reference a job can have a status that is notFAILED(orCANCELLED) that do not throw an error message. The current validation of the status of the job only checks if the job is not inRUNNINGnor it is aCOMPLETEDjob and throws and error if so, but if for some reason the job is inPENDINGor any other status that doesn't represent a failed job it will throw an error with an empty message.