feat(content-manager): add non-mutating rules plan - #181
Draft
AAH20 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: aah20 <aah20@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rules plancommand that compares local rule content and deployment settings with Google SecOpsWhy
Rule updates currently move directly from local configuration to mutation APIs. Operators need a reviewable preview before changing production detections, especially in CI/CD and change-control workflows. This adds that preview without changing the existing update path.
The plan can be retained as machine-readable evidence, compared across runs, or reviewed before a separate update invocation.
Safety
The planner only loads local rules and reads remote rules. A regression test replaces the create, revision-update, and deployment-update functions and verifies that none are called.
Plan output deliberately omits rule source text and Google Cloud resource names.
Testing
PYTHONPATH=tools/content_manager pytest -q tools/content_manager/content_managerpython -m py_compile tools/content_manager/content_manager/rules.py tools/content_manager/content_manager/__main__.py tools/content_manager/content_manager/test_rules.pypython -m content_manager rules --help