fix: add padding to ellipsis button for larger tap target#62
Closed
12britz wants to merge 1 commit into
Closed
Conversation
The ellipsis button in player controls had a hit box that was too small, making it difficult to tap reliably. Added 8pt padding to increase the tappable area while keeping the visual size unchanged. Fixes ciderapp#42
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The ellipsis menu button in
AdditionalControlshad a hit box constrained to just the icon size, making it difficult to tap reliably on touch devices.Fix
Added
.padding(8)before the.frame()modifier. This increases the tap target while keeping the visual appearance unchanged.Fixes #42
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.