Initialize values in jsoncpp. #1200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due do compiling json with -Werrro, g++ (Debian 14.2.0-19) 14.2.0 fails with "warning: '*(Json::Value::ValueHolder*)this' is used uninitialized". The default constructor uses nullValue to initialize the Value without a value. When calling method swapPayload() with such an object, the uninitialized internal value gets accessed. As a simple workaround set new Value objects to integer 0. Signed-off-by: Alexander Bluhm <[email protected]>
| case tokenNull: | ||
| { | ||
| Value v; | ||
| Value v(0); |
There was a problem hiding this comment.
Since Value exists with a default ctor (one that takes nullValue by default) this is not, IMHO, the right change. The default ctor shall be changed so that it correctly initialize all the Value properties when called (this is not done if it's called without any parameter or if it's called with vtype = nullValue).
The same goes for the other occurences of the same change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due do compiling json with -Werrro, g++ (Debian 14.2.0-19) 14.2.0 fails with "warning: '(Json::Value::ValueHolder)this' is used uninitialized". The default constructor uses nullValue to initialize the Value without a value. When calling method swapPayload() with such an object, the uninitialized internal value gets accessed. As a simple workaround set new Value objects to integer 0.