Fix build errors against wxWidgets 3.3 - #1055
Merged
Merged
Conversation
Newer wxWidgets removes implicit conversions that older releases tolerated: - wxT() string literals no longer concatenate with std::string / std::wstring operands; wrap both sides in explicit wxString constructors (AppFrame, BookmarkView). - std::wstring no longer streams into std::cout implicitly; convert to std::string for log output (SessionMgr, GLFont). No functional changes, output and labels are identical.
cjcliffe
self-requested a review
September 2, 2026 01:26
Owner
|
Looks good and still compiles with older wxWidgets -- thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CubicSDR fails to compile against wxWidgets 3.3 (current Homebrew release on macOS). Newer wxWidgets removes implicit conversions that older releases tolerated:
wxT()literals no longer concatenate withstd::string/std::wstringoperands (AppFrame.cpp,BookmarkView.cpp)std::wstringno longer streams intostd::coutimplicitly (SessionMgr.cpp,GLFont.cpp)Fix
Wrap the affected concatenations in explicit
wxStringconstructors and convert wide strings before streaming to stdout. No functional changes; labels and log output are identical.Testing
Builds and runs cleanly on macOS (arm64) against Homebrew wxWidgets 3.3; menu labels, bookmark dialogs, and session/font log lines render as before.
🤖 Generated with Claude Code