Skip to content

Updated: A demo test whose request gets no answer says whether the demo's server ended, and how #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
se7enxweb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated: A demo test whose request gets no answer says whether the demo's server ended, and how #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/DemoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function withDemo(callable $body, string $prefix = '', array $env = []): void
usleep(100000);
}
try {
$body(function (string $method, string $uri, array $headers = [], string $content = '') use ($port, $prefix): array {
$body(function (string $method, string $uri, array $headers = [], string $content = '') use ($port, $prefix, $proc): array {
$h = '';
foreach ($headers as $k => $v) {
$h .= "$k: $v\r\n";
Expand All @@ -61,6 +61,13 @@ function withDemo(callable $body, string $prefix = '', array $env = []): void
$cookies[$m[1]] = $m[2];
}
}
if ($status === 0) {
// No answer: say whether the server is gone (and how) rather than leave a bare 0 to the caller.
$st = proc_get_status($proc);
if (!$st['running']) {
throw new TestFailure("$method $uri: no answer, the demo's server ended -- " . ($st['signaled'] ? 'signal ' . $st['termsig'] . ' (11: PHP crashed)' : 'exit ' . $st['exitcode']));
}
}
$location = null;
foreach ($http_response_header ?? [] as $line) {
if (stripos($line, 'Location:') === 0) {
Expand Down
Loading